rogerta / rlz

Library for grouping promotion event signals and anonymous user cohorts.
Other
92 stars 61 forks source link

Should add a new access point for ChromeFrame #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
We should add a new access point for ChromeFrame.  

Chrome's access points are "C1" and "C2", so we should add "C3".  

Separately, ChromeFrame should be modified to call with this new access point, 
instead of using C1, but that's a separate bug.

Original issue reported on code.google.com by gwil...@chromium.org on 5 Oct 2010 at 11:24

GoogleCodeExporter commented 9 years ago
Roger, Glenn, in rlz side is just a matter of adding a:
case CHROME_FRAME: return "C3";

to the GetAccessPointName function?

Like we do for CHROME_OMNIBOX at win/lib/lib_values.cc +100 ?

Glenn, did you have the ChromeFrame bug number?

Original comment by tfar...@chromium.org on 25 Oct 2010 at 5:22

GoogleCodeExporter commented 9 years ago
Hi Thiago,

The new access point as already been added to RLZ, see revision r24.  What 
remains is to make the appropriate calls in Chrome Frame.  I think the bug you 
are looking for is: http://code.google.com/p/chromium/issues/detail?id=58076

Original comment by roge...@google.com on 25 Oct 2010 at 5:36

GoogleCodeExporter commented 9 years ago

Original comment by roge...@google.com on 26 Sep 2011 at 8:25

Palash96 commented 6 years ago

Help me