rogerta / secrets-for-android

Securely store and manage passwords and secrets on your Android phone.
70 stars 36 forks source link

Enhancements for pop-up menu #100

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I took the liberty to make a few changes by myself. changes are:

1- pop-up menu now have "login to clip" and "Secret to clip" options
2- floating message says what was copied to clip

patch follows if you're interested.

Original issue reported on code.google.com by bento...@gmail.com on 10 May 2011 at 2:41

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch bento.  Patch looks good except its English specific.  
Comments:

- cannot hard code strings like "Secrets" and "Login", since that will not work 
in languages other than English.  Please create a string resource for each and 
try to determine the correct word for each of the supported languages.  Use the 
existing string resource files for hints

- you need to change the copied_to_clipboard string for all languages, not just 
English

Are you able to created a new patch?  Thanks again.

Original comment by roge...@google.com on 11 May 2011 at 2:37

GoogleCodeExporter commented 9 years ago
doing that right now. moved "Secrets" and "Logins" to strings.xml and did the 
translation to spanish (that was the easy ones), i'll try to figure out how to 
translate those terms to the other languages.

speaking in translation, would you be interestes in a translation to pt_BR ?

Original comment by bento...@gmail.com on 11 May 2011 at 5:05

GoogleCodeExporter commented 9 years ago
If you can translate to pt-BR, that would be great!  Thanks.

Original comment by roge...@google.com on 11 May 2011 at 5:48

GoogleCodeExporter commented 9 years ago
new patch with all the corrections. I tested in a few languages and looks OK.

I'll work on a translation to portuguese on the weekend and open another issue 
to submit the patch.

Original comment by bento...@gmail.com on 11 May 2011 at 6:12

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for submitting your patch bento.  It has been committed as r146.  I 
changed two things:

- replaced 'login' with 'username' and 'secret' with 'password' to keep the 
variable names consistent with the rest of the code
- merge the two switch cases since most of the code is common

Can't wait for your pt-BR translation.  My mom, who is originally from, and 
grew up in, Botafogo Beach will be happy ;-)  While I can speak a fairly broken 
Portuguese, I unfortunately do not read or write it.

Original comment by ro...@tawacentral.net on 23 May 2011 at 4:01