rogora / hangish

A Google Hangouts native client for Sailfish
38 stars 7 forks source link

Cannot save more than one image from messages on a given day. #39

Closed stephgosling closed 8 years ago

stephgosling commented 8 years ago

In some cases (perhaps not all?) I can only successfully download the first image I attempt to from a chat conversation I think because Hangish is saving images in the format YYYY-MM-DD and is silently failing when an image of that name already exists.

Version affected: 0.8.2 (as available from the store) Steps to reproduce:

If you mv the first image out of the way the download will succeed (and then tracker gets upset but that's not your problem ;) )

rogora commented 8 years ago

This is interesting. Hangish uses the id that Google gives to the image, parsed from the url. So the name of the file should not be the problem.

About your curiosity: the name is saved without the extension because the image can be have different formats, but the format cannot be parsed from the url. So, the easy hack to make sailfish always display the image correctly, was to remove the extension from the filename.

stephgosling commented 8 years ago

Yes I saw the extension stripping in the source comments so that does make sense (and tracker picks them up regardless). Regarding the saving issue I'd be curious to see if you are able to reproduce (we may all need to send pictures of kittens to each other or something ;) )