search

rogpeppe / go-internal

Selected Go-internal packages factored out from the standard library
BSD 3-Clause "New" or "Revised" License
825 stars 67 forks source link

testscript: \r\n vs \n in txtar files #178

Closed bep closed 1 year ago

bep commented 1 year ago

I had a test passing on Unix, failing on Windows that had me scratch my head for a while.

I have reproduced it here:

https://github.com/bep/issuerepros/blob/c2315e49343a698289d2525a5e1d348228fbb03a/testscripts/newlines/newlines.txt

So, for files stored via txtar there is a newline difference that makes it impossible to create files with equal content, which normally isn't a big deal, but was in my case (I used these files as placeholders to test out a checksum file function).

I can work around it in my test by just copy some files into the work dir, but it would be great if this could somehow be fixed.

bep commented 1 year ago

OK, searching a little, I see #106 which I guess is similar. A unix2dos command sounds like a workable solution, I'll close this for now. It's not ideal, but I guess fixing this will make the Windows people unhappy ...