search

rogpeppe / go-internal

Selected Go-internal packages factored out from the standard library
BSD 3-Clause "New" or "Revised" License
825 stars 67 forks source link

diff: add package, make testscript use it #205

Closed mvdan closed 1 year ago

mvdan commented 1 year ago

(see commit messages - please do not squash)

Fixes #157.

mvdan commented 1 year ago

CC @thepudds

mvdan commented 1 year ago

Roger agreed in https://github.com/rogpeppe/go-internal/issues/157#issuecomment-1138731948, and again in voice, so I'm merging :)

thepudds commented 1 year ago

Hi @mvdan , looks great, and thanks! (Sorry, this was still on my to do list, but not my "Burning Must Do Now" list 😅 ).

Would it make sense to remove or modify as well (currently still there on master):

https://github.com/rogpeppe/go-internal/blob/50a14409f175f086f5f0f343bf3e06ca917da08b/testscript/cmd.go#L144-L152

mvdan commented 1 year ago

Oh my, how did I miss that? Happy to approve and merge a PR if you send one, otherwise I'll send one in a bit and you can approve.