search

rogpeppe / go-internal

Selected Go-internal packages factored out from the standard library
BSD 3-Clause "New" or "Revised" License
823 stars 67 forks source link

Accept `!` for negation without requiring a space #215

Closed ldemailly closed 1 year ago

ldemailly commented 1 year ago

Fixes #190

mvdan commented 1 year ago

Sorry, but I don't think this is a good idea. The testscript syntax is simple and it should stay that way. Neither POSIX Shell nor Bash even support removing the space after !, so this doesn't bring us any closer to syntax that people are used to. I'll review Axel's PR instead.

ldemailly commented 1 year ago

for the record, re consistency:

lines like

[!exec:false] skip

aren't

[ ! exec:false ] skip