search

rogual / neovim-dot-app

Mac OS X GUI for Neovim
1.13k stars 62 forks source link

Drawing the background rectangle draws an extra pixel #160

Closed bambu closed 9 years ago

bambu commented 9 years ago

Fixed vertical line that appears when closing out of an autocomplete window. This would also happen when there is a vertical split and one goes up/down a line in the left most window. This was due to an extra pixel being drawn at times when drawing the background. Brought down the width of the drawing of the background and it appears to fix it.

This should fix #137

rogual commented 9 years ago

I'm uneasy about this one. Why is the magic number 1.01? Why not 1.001? Is it the same for all fonts? I mean, there's a reason why the widths aren't matching up and adding an arbitrary constant doesn't seem like it's the right fix.

Not that I have any better ideas right now.

bambu commented 9 years ago

The magic number is purely magic. I had tested it with a few different fonts and a few different font sizes and it had worked. There is definitely some sort of math issue with the drawing that I havent been able to figure out and thus the "magic".

I just tested this on a different device and it doesn't really do anything .05 - .01 (which was the range i had previously determined) doesn't seem to make a change.

rogual commented 9 years ago

Alright, let's do it.