search

rogual / neovim-dot-app

Mac OS X GUI for Neovim
1.13k stars 62 forks source link

Added ability to enable/disable Anti-aliasing #247

Closed bambu closed 8 years ago

bambu commented 8 years ago

One can now call MacFontShouldAntialias() with 1 or 0 to enable/disable Anti-aliasing on fonts.

This is for #220

rogual commented 8 years ago

Thanks for this. One thing, I don't know that it makes sense to store preferences set with MacSetXXX into user defaults.

I would think, intuitively, that these settings should act like Vim's own set settings and only take effect for the current session.

That said, this is the feedback I gave to https://github.com/rogual/neovim-dot-app/pull/197 and OP simply disappeared, so perhaps I should be less picky :)

bambu commented 8 years ago

Changed. Now if a user wants to always have a anti-aliasing disabled, they will need to have something like 

if exists("g:neovim_dot_app")
  call MacFontShouldAntialias(0)
endif
rogual commented 8 years ago

Thanks @bambu! I made one small change when merging this: I renamed the API to MacSetFontShouldAntialias. Hope you don't mind & can see why.

bambu commented 8 years ago

Don't mind at all. That's what I originally I originally called it. Then changed it thinking the name was too long