Closed ghost closed 8 years ago
I don't know much about scons
either but I don't think this does what @rogual intended. I think the nvim_dot_app.txt
is supposed to be copied into the neovim docs dir. This doesn't appear to be copied after running make
:
git/neovim-dot-app ‹master*› » find . -name "nvim*.txt"
./build/Neovim.app/Contents/Resources/runtime/doc/nvim.txt
./build/Neovim.app/Contents/Resources/runtime/doc/nvim_clipboard.txt
./build/Neovim.app/Contents/Resources/runtime/doc/nvim_from_vim.txt
./build/Neovim.app/Contents/Resources/runtime/doc/nvim_provider.txt
./build/Neovim.app/Contents/Resources/runtime/doc/nvim_python.txt
./build/Neovim.app/Contents/Resources/runtime/doc/nvim_terminal_emulator.txt
./doc/nvim_dot_app.txt
Thanks, but this wasn't the right fix. Fixed in https://github.com/rogual/neovim-dot-app/commit/82b83845a131ea19dd86d9d018cebec4df7b4fc6.
Cool thanks
In response to #253:
The error in this issue appears to happen here, where the neovim-dot-app docs are added to the nvim docs within the built app (
build/Neovim.app/Contents/Resources/runtime/doc
). This error is only encountered on clean builds, and not on subsequent builds.While not well versed in
scons
, it seems that this is caused by this line. Based on my research, theVariantDirectory
is only set when the build dir does not yet exist. It seems this causes thedoc
install to look relative to this directory, and errors since all of thedoc
files are already present. The fix was to look up one directory from thebuild
dir, which would be the project root, and here thedoc
dir can be found and its files can be written. On subsequent builds, theVariantDir
is not set, thedoc
dir is located in the project root and everything succeeds again.There might be a better way to do this according to
scons
best practices, but this is how I got it to work.