rogual / neovim-dot-app

Mac OS X GUI for Neovim
1.13k stars 62 forks source link

Compilation failure due to msgpack incompatibility #281

Closed Stickerpants closed 8 years ago

Stickerpants commented 8 years ago

I notice that #272 was merged, but I still got the same msgpack compilation error when I tried to install via homebrew. Output is pasted below - has the fix just not been fully deployed yet, or are there more issues?

==> Summary
🍺  /usr/local/Cellar/neovim/0.1.4: 1,328 files, 17.9M, built in 4 minutes 33 seconds
==> Installing rogual/neovim-dot-app/neovim-dot-app
==> Downloading https://github.com/rogual/neovim-dot-app/archive/0.1.4.tar.gz
==> Downloading from https://codeload.github.com/rogual/neovim-dot-app/tar.gz/0.1.4
######################################################################## 100.0%
==> make NVIM=/usr/local/opt/neovim/bin/nvim
Last 15 lines from /Users/kris/Library/Logs/Homebrew/neovim-dot-app/01.make:
VIM=/usr/local/Cellar/neovim/0.1.4/share/nvim NVIM=/usr/local/opt/neovim/bin/nvim scons -Q
Install file: "res/Info.plist" as "build/Neovim.app/Contents/Info.plist"
clang++ -o build/client.o -c -std=c++11 -stdlib=libc++ -g -Wno-deprecated-register -I/usr/local/Cellar/msgpack/2.0.0/include -Ibuild -Isrc src/client.cc
src/client.cc:48:20: error: no matching member function for call to 'next'
    while(unpacker.next(&unpacked)) {
          ~~~~~~~~~^~~~
/usr/local/Cellar/msgpack/2.0.0/include/msgpack/v2/unpack.hpp:1335:23: note: candidate function not viable: no known conversion from 'msgpack::unpacked *' (aka 'msgpack::v1::object_handle *') to 'msgpack::object_handle &' for 1st argument; remove &
inline bool unpacker::next(msgpack::object_handle& result) {
                      ^
/usr/local/Cellar/msgpack/2.0.0/include/msgpack/v2/unpack.hpp:1320:23: note: candidate function not viable: requires 2 arguments, but 1 was provided
inline bool unpacker::next(msgpack::object_handle& result, bool& referenced) {
                      ^
1 error generated.
scons: *** [build/client.o] Error 1
make: *** [all] Error 2
bambu commented 8 years ago

272 was merged. However, it doesn't seem that @rogual did a new release. It should build when getting the latest. This can be done by running the following command:

brew install --HEAD neovim-dot-app
Stickerpants commented 8 years ago

I see, that makes sense. Thank you for the update! I have no further questions on this, so I'll close it now.

alexmarchant commented 8 years ago

Ran into this issue today as well, @bambu's answer fixed this for me, but perhaps the brew release could be updated @rogual?