search

rogual / neovim-dot-app

Mac OS X GUI for Neovim
1.13k stars 62 forks source link

Disable ligatures to prevent rendering issues #305

Closed sfuller closed 7 years ago

sfuller commented 7 years ago

Fix for #304. Added the value 0 for the key NSLigatureAttributeName in mTextAttrs to disable drawing ligatures.

PixelPirate commented 7 years ago

There are other fonts (e.g.: https://github.com/i-tu/Hasklig) that use ligatures for ->  → conversions. Probably some neovim-dot-app users would like to use such fonts, so disabling ligatures in general seems like the wrong decision.

bambu commented 7 years ago

Agreed. There are some that enjoy ligatures. How about having disabled ligatures as a setting that can be placed in your config file if you want to use a font without its ligatures?

I suggest having disable, be the option because if a person sets their font to a ligature based font, then they will be surprised when the ligatures do not appear.

KixPanganiban commented 7 years ago

I second @PixelPirate and @bambu. Please don't disable ligatures as a hard default. I use Fira Code and ligatures make looking at the code much more enjoyable. Instead, consider making it a setting.

rogual commented 7 years ago

It would be desirable to support ligatures in the future, but they are currently not supported at all. Sometimes they render, sometimes they don't — it's arbitrary and depends on where and when the characters are redrawn. I consider this a bug.

In summary, I'd rather have (in order of preference):

  1. Working ligatures
  2. No ligatures
  3. Broken ligatures (current state)