search

roguerb / pull-request-workshop

0 stars 6 forks source link

Subtract method is painfully counterintuitive #12

Closed mistertime closed 8 years ago

mistertime commented 8 years ago

I'd say we all agree that strcpy was a mistake, yes? Let's not perpetuate such horrors. The subtract method subtracts the first argument from the second, a grievous infraction against common English syntax and, by extension, the majority of programming conventions.

conroywhitney commented 8 years ago

Haha @mistertime. That's awesome. Thanks for pointing that out.

Would you mind creating a Pull Request that fixes that method, as well as updates the specs so that this issue doesn't crop up in the future?

Thanks!

conroywhitney commented 8 years ago

Closing this Issue after merging in the project's Code of Conduct in PR #20. While the content of this issue is valid (these methods are wrong), the way it is phrased violates the new Code of Conduct, specifically in regards to "disparaging personal remarks".

We'll open a new issue.