Closed conroywhitney closed 8 years ago
What's more, Rubocop gives an error with it currently:
rogue_math.rb:2:19: W: Lint/UnusedMethodArgument: Unused method argument - b. If it's necessary, use _ or _b as an argument name to indicate that it won't be used. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
def self.add(a, b)
^
I guess that should be a + b in adder ?
Hey @programmin1. Thanks for pointing this out!
You're right -- our project doesn't currently even pass our own style guides!
Could you please create a separate issue called something like "Fix linter warnings" so that we can work on fixing this?
Thanks!
@programmin1 Haha, I was too slow. I just saw your PR #6 and left some feedback there. Thanks!
Thanks @conroywhitney, please see #8
Hey @programmin1. I actually just recently closed #8 and left some comments there as to why. Thanks!
Closing RE: PR #14
Since we require that all PRs conform to our coding styles, we should provide instructions for how to run
rubocop
in theREADME
file.