search

roguerb / pull-request-workshop

0 stars 6 forks source link

Add rubocop instructions to README #2

Closed conroywhitney closed 8 years ago

conroywhitney commented 8 years ago

Since we require that all PRs conform to our coding styles, we should provide instructions for how to run rubocop in the README file.

programmin1 commented 8 years ago

What's more, Rubocop gives an error with it currently:

rogue_math.rb:2:19: W: Lint/UnusedMethodArgument: Unused method argument - b. If it's necessary, use _ or _b as an argument name to indicate that it won't be used. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
  def self.add(a, b)
                  ^

I guess that should be a + b in adder ?

conroywhitney commented 8 years ago

Hey @programmin1. Thanks for pointing this out!

You're right -- our project doesn't currently even pass our own style guides!

Could you please create a separate issue called something like "Fix linter warnings" so that we can work on fixing this?

Thanks!

conroywhitney commented 8 years ago

@programmin1 Haha, I was too slow. I just saw your PR #6 and left some feedback there. Thanks!

programmin1 commented 8 years ago

Thanks @conroywhitney, please see #8

conroywhitney commented 8 years ago

Hey @programmin1. I actually just recently closed #8 and left some comments there as to why. Thanks!

conroywhitney commented 8 years ago

Closing RE: PR #14