Make rubocop happy, no warning, and fix add

roguerb / pull-request-workshop

0 stars 6 forks source link

Make rubocop happy, no warning, and fix add #6

Closed programmin1 closed 8 years ago

programmin1 commented 8 years ago

Fix warning for rubocop.

casto101 commented 8 years ago

LGTM 👍

conroywhitney commented 8 years ago

Hey @programmin1. Thanks for submitting this pull request!

You're right -- this does fix both the linter, and it seems, the problem that was identified in Issue #5.

Would you please add some tests that show how the add method was broken before, and prove that it is working now?

Thanks!

seanculver commented 8 years ago

It looks like your PR'ng from the master branch on your fork, this might cause issues later on if this PR does not get merged. We would recommend that you create a feature branch on your fork.

Thanks!

conroywhitney commented 8 years ago

Actually, I'm going to close this PR since #10 fixed both the add method as well as got rid of the related rubocop errors. Thanks for submitting this @programmin1!