rohan472000 / reliance-stock-price-prediction-LSTM

Implemented LSTM model to predict Reliance stock prices, achieving accurate forecasts for 10 days.
MIT License
9 stars 4 forks source link

Error 403: permission denied #2

Closed rohan472000 closed 1 year ago

rohan472000 commented 1 year ago

I'm trying to push and commit changes in this repo through YAML script in github workflows, but getting Error 403.

Kindly, look in this issue in Actions, modify it.

Amarjit0511 commented 1 year ago

I think the problem might be with the scope selected for access tokens.

rohan472000 commented 1 year ago

No..it's something else as I tried with token and without token also ..got same error 403

joelmathewphilip commented 1 year ago

@rohan472000 Created PR https://github.com/rohan472000/reliance-stock-price-prediction-LSTM/pull/8 to fix this issue.

The documentation for git-auto-commit-action specifies this setting. You can find it here https://github.com/stefanzweifel/git-auto-commit-action#:~:text=Set%20the%20contents%2Dpermission%20of%20the%20default%20GITHUB_TOKEN%20to%20true.%20(Required%20to%20push%20new%20commits%20to%20the%20repository)

3

rohan472000 commented 1 year ago

Kindly see the error in Actions - https://github.com/rohan472000/reliance-stock-price-prediction-LSTM/actions/runs/6364909352/job/17281520328

joelmathewphilip commented 1 year ago

The error is due to protection policies on the main branch, direct commits are not allowed. Are you open to creating a PAT token with the required permissions to update the main branch ?

rohan472000 commented 1 year ago

I dont have set any rules on main.

joelmathewphilip commented 1 year ago

Can you confirm if the below settings are present ? image

rohan472000 commented 1 year ago

Show me path for it quickly

joelmathewphilip commented 1 year ago

Settings -> General Actions image

rohan472000 commented 1 year ago

Done..now try again.

rohan472000 commented 1 year ago

@joelmathewphilip

https://github.com/rohan472000/reliance-stock-price-prediction-LSTM/actions/runs/6368460411/job/17287830383

joelmathewphilip commented 1 year ago

It failed. I am not sure what protection rules are triggering, as you said there is none setup. Can you create a PAT token with admin access and store it as a github secret ? Please share the secret name once you have created it.

rohan472000 commented 1 year ago

ok...

rohan472000 commented 1 year ago

@joelmathewphilip ADMIN_PAT

rohan472000 commented 1 year ago

@joelmathewphilip kindly specify which access should be added to PAT as still access issue is there if I'm getting it correctly.

joelmathewphilip commented 1 year ago

@rohan472000 Now it says, even you don't have access to make changes. There is some other rule triggering in the backend image

rohan472000 commented 1 year ago

wait let me make it again.

rohan472000 commented 1 year ago

@joelmathewphilip ADMIN_PAT, try again.

joelmathewphilip commented 1 year ago

Hope the secret name is the same. Can you trigger the workflow manually ? I don't have access to do that. Otherwise, I will have to open an unwanted PR.

rohan472000 commented 1 year ago

ok...sure

joelmathewphilip commented 1 year ago

It worked ! https://github.com/rohan472000/reliance-stock-price-prediction-LSTM/actions/runs/6368665366/job/17288325161

rohan472000 commented 1 year ago

Thanks @joelmathewphilip for your contributions.

If interested then look other repo of mine, where workflows related or other potential issue is there, will appreciate your contributions.

joelmathewphilip commented 1 year ago

Another issue exists though. Each commit is creating a chain of github action runs, which shouldn't have happened, if we use the default github token.
image I suggest disabling the trigger on the main branch for now, until we find a fix for this.

rohan472000 commented 1 year ago

yeah ...not sure why this is happening.

joelmathewphilip commented 1 year ago

Please review and approve https://github.com/rohan472000/reliance-stock-price-prediction-LSTM/pull/12.

joelmathewphilip commented 1 year ago

Created another PR which should hopefully fix the error https://github.com/rohan472000/reliance-stock-price-prediction-LSTM/pull/13. Please review and approve

rohan472000 commented 1 year ago

If possible, can you make a check that checks if code is doing what it expect to do without affecting main??

joelmathewphilip commented 1 year ago

Can you elaborate on that ?

rohan472000 commented 1 year ago

I want to see changes a PR do on main without merging.

joelmathewphilip commented 1 year ago

okay, I think that can be done. Can you create a new issue for it ? As this issue is fixed

rohan472000 commented 1 year ago

Ya sure ..

rohan472000 commented 1 year ago

@joelmathewphilip see #14