rohan843 / dnncase

GNU General Public License v3.0
1 stars 0 forks source link

Improve `reuse` block #5

Closed rohan843 closed 1 year ago

rohan843 commented 1 year ago

In a later prototype, improve the reuse block in the testing-1 branch to allow for actually choosing what layer to reuse.

Rohanray2005 commented 1 year ago

We can define information of a node by two fields 1) type 2) subtype , type will give information about type of layer and subtype will tell whether it is normal layer or reuse layer.

rohan843 commented 1 year ago

Yup, we can also come up with a way to allow for modification of the layer being reused. We'll have to see how to allow for the layer that is reused to be changed. We may consider keeping the reuse property as a supertype instead of a subtype for this.

Rohanray2005 commented 1 year ago

Yeah ! for that i think subtype will work , user will add a layer with subtype as normal and then this subtype can be changed to reuse, this way we only need to implement one button to convert subtype normal to reuse, on the other hand if we convert the reuse block to some layer we have to provide so many options corresponding to layer.

rohan843 commented 1 year ago

We can finalize on this in 2nd prototype, also ig is best to see how a hypermodel for kerasTuner will have to be created as well, as it also requires a subtype based structure. We might be able to combine the 2 approaches.

rohan843 commented 1 year ago

Discussion to be continued here: https://github.com/rohan843/dnncase/issues/16