rohankhayech / Choona

Guitar tuner app for Android with support for custom tunings.
https://play.google.com/store/apps/details?id=com.rohankhayech.choona
GNU General Public License v3.0
4 stars 0 forks source link

[BUG] Custom tuning name persists on main screen after deletion. #5

Closed rohankhayech closed 1 year ago

rohankhayech commented 1 year ago

Describe the bug The previously saved name of the currently selected custom tuning persists on the tuning selection dropdown on the main screen even after the custom tuning is deleted, until the tuning is changed.

To Reproduce Steps to reproduce the behaviour:

  1. Create a custom tuning using the tune up/down buttons.
  2. Open the tuning selection screen.
  3. Save the current tuning with a custom name.
  4. Go back to the main screen.
  5. Reopen the tuning selection screen.
  6. Delete the custom tuning.
  7. Dismiss the tuning selection screen without selecting a new tuning.
  8. The custom name should still be visible on the main screen.

Expected behaviour The tuning should display the strings in the tuning after a custom tuning is deleted rather than it's previously saved name.

Device and version info:

rohankhayech commented 1 year ago

Fixed for v1.0.1 release.