search

rohanpai / Robinhood

Python Framework to make trades with Robinhood Private API
MIT License
81 stars 22 forks source link

Added features #1

Open dsouzarc opened 9 years ago

dsouzarc commented 9 years ago

Added some more features and methods to Robinhood.py, and adapted example.py to showcase a few of those features.

Also organized the code and added comments to both Robinhood.py and example.py

Updated the README.md to reflect those changes and provide more details

dsouzarc commented 9 years ago

Made the recommended changes

rohanpai commented 9 years ago

:+1: @dsouzarc looks good, combine changes into one commit and let's merge this!

iamseth commented 9 years ago

I have an issue with the use of raw_input which is CLI and Python 2 bias (raw_input removed in Python3). IMO, the API should require a symbol and let a new CLI module handle arguments and/or input.

Also, is there a reason why session, username, password, etc are done as class variables rather than instance variables? The latter seems much more reasonable because if you create more than one instance of this class, things will get weird :)