search

rohbotics / pifi

A headless wifi provisioning system.
46 stars 12 forks source link

AP channel fix #25

Closed MoffKalast closed 3 years ago

MoffKalast commented 3 years ago

So turns out what seems to be the issue with picking an AP mode channel is the same as the autoconnect issue, in that the NM expects a boolean or in this case a uint32, when it gets a string and throws a tantrum.

Confirmed working using the manual install option mentioned in the ReadMe.

Anyhow I would suggest looking up all the other params that can exist that aren't strings, and adding the manual type correction for all so we can finally call it good.

rohbotics commented 3 years ago

This PR has a formatting issue, so I fixed that and merged manually. In the future please use black to auto-format.

The python-network manager purports to handle this type of conversion internally, but clearly it doesn't always work.. sigh. Glad you figured this one out, thanks.

MoffKalast commented 3 years ago

Ah noted, I just edited it on github to do a quick test but figured it was formatted alright since it ran fine. Anyhow.