search

rohbotics / xv_11_laser_driver

49 stars 50 forks source link

Noetic release #7

Closed Timple closed 4 years ago

Timple commented 4 years ago

Would you mind releasing this package also for the newest distribution ROS Noetic? :)

rohbotics commented 4 years ago

Can you make sure that the package compiles and runs under noetic?

If it does, I will do a release :)

Timple commented 4 years ago

I can verify that the package compiles. However I don't have the hardware at hand to validate...

Looking at the code I expect it to run as-is. So the options are: A) release and wait for bug-reports, B) wait until someone gets their hand on the hardware (can be a while in these strange times unfortunately).

jetdillo commented 4 years ago

I think I still have a Neato LIDAR rattling around in a box somewhere. Compiling might suffice for a quick turn-around release though. I suspect that most of the users of v_11_laser_driver are working with legacy hardware where the firmware could be considered stable so chances are if it worked over the past few releases, it's probably still working today. JMO, 'dillo

On Tue, Jul 7, 2020 at 12:12 AM Tim Clephas notifications@github.com wrote:

I can verify that the package compiles. However I don't have the hardware at hand to validate...

Looking at the code I expect it to run as-is. So the options are: A) release and wait for bug-reports, B) wait until someone gets their hand on the hardware (can be a while in these strange times unfortunately).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rohbotics/xv_11_laser_driver/issues/7#issuecomment-654647297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHVC5V7JAVMCPSRGSL2STR2LDGPANCNFSM4OAQKVFA .

rohbotics commented 4 years ago

Ok I did the release, hopefully it all works as expected.

https://github.com/rohbotics/rosdistro/pull/new/bloom-xv_11_laser_driver-3