rohe / oictest

OAuth2 and OpenID Connect test tools
Other
39 stars 21 forks source link

infinite loop in sort_flows_into_graph #18

Closed theloi closed 10 years ago

theloi commented 10 years ago

In sort_flows_into_graph the flows oic-token-userinfo and oic-token-userinfo_bb will never resolve their dependency mj-02 because it is commented out. Thus the while loop in oic_flow_tests.py never ends.

I invoke oic_flow_tests from the shell like this:

oic_flow_tests.py -e myop

So the question is why is mj-02 commented out?

Sorry, don't want to flood you with issues. I just report what I find and if I can solve it right away I would present a pull request.

Cheers O.

rohe commented 10 years ago

6 sep 2014 kl. 16:12 skrev theloi notifications@github.com:

In sort_flows_into_graph the flows oic-token-userinfo and oic-token-userinfo_bb will never resolve their dependency mj-02 because it is commented out. Thus the while loop in oic_flow_tests.py never ends.

I invoke oic_flow_tests from the shell like this:

oic_flow_tests.py -e myop

So the question is why is mj-02 commented out?

mj-02 as well as oic-token-userinfo and oic-token-userinfo_bb all should be removed because return_type=token is not part of the OpenID Connect specification.

— Roland

”Being able to think like a child is an important attribute of being an adult” - Eddie Izzard

theloi commented 10 years ago

This commit fixes this issue. Just tested it. Thanks!!!

rohe commented 10 years ago

8 sep 2014 kl. 20:20 skrev theloi notifications@github.com:

This commit fixes this issue. Just tested it. Thanks!!!

Your welcome !

— Roland

”Being able to think like a child is an important attribute of being an adult” - Eddie Izzard