rohit-px2 / nvui

A modern frontend for Neovim.
MIT License
1.72k stars 49 forks source link

Compilation fails on Linux / Guix #112

Closed tex closed 2 years ago

tex commented 2 years ago

Hello,

I am creating a package for Guix and got this.

How does this even compile for you?

[ 60%] Building CXX object CMakeFiles/nvui_test.dir/src/titlebar.cpp.o
/gnu/store/vakvgvrb839igv16jkif4lmx11d25jqb-gcc-10.3.0/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_THREAD_DYN_LINK -DFMT_LOCALE -DFMT_SHARED -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WIDGETS_LIB -I/tmp/guix-build-nvui-0.2.1.drv-0/build -I/tmp/guix-build-nvui-0.2.1.drv-0/source -I/tmp/guix-build-nvui-0.2.1.drv-0/build/nvui_test_autogen/include -I/tmp/guix-build-nvui-0.2.1.drv-0/source/test -I/tmp/guix-build-nvui-0.2.1.drv-0/source/src -isystem /gnu/store/3ag62qr53br83x0p0739xdhshd3km7yk-qtbase-5.15.2/include/qt5 -isystem /gnu/store/3ag62qr53br83x0p0739xdhshd3km7yk-qtbase-5.15.2/include/qt5/QtCore -isystem /gnu/store/3ag62qr53br83x0p0739xdhshd3km7yk-qtbase-5.15.2/lib/qt5/mkspecs/linux-g++ -isystem /gnu/store/3ag62qr53br83x0p0739xdhshd3km7yk-qtbase-5.15.2/include/qt5/QtGui -isystem /gnu/store/3ag62qr53br83x0p0739xdhshd3km7yk-qtbase-5.15.2/include/qt5/QtWidgets -isystem /gnu/store/5jixar8hqbwmm302h2r04kw6g4268qyk-qtsvg-5.15.2/include/qt5 -isystem /gnu/store/5jixar8hqbwmm302h2r04kw6g4268qyk-qtsvg-5.15.2/include/qt5/QtSvg -O2 -g -DNDEBUG -Wall -Wextra -pedantic -Werror -Wfatal-errors -Wno-language-extension-token -fPIC -std=gnu++2a -MD -MT CMakeFiles/nvui_test.dir/src/titlebar.cpp.o -MF CMakeFiles/nvui_test.dir/src/titlebar.cpp.o.d -o CMakeFiles/nvui_test.dir/src/titlebar.cpp.o -c /tmp/guix-build-nvui-0.2.1.drv-0/source/src/titlebar.cpp
/tmp/guix-build-nvui-0.2.1.drv-0/source/src/grid.cpp:155:47: error: extra ‘;’ [-Werror=pedantic]
  155 | QPoint GridBase::top_left() { return {x, y}; };
      |                                               ^
/tmp/guix-build-nvui-0.2.1.drv-0/source/src/grid.cpp:155:47: error: extra ‘;’ [-Werror=pedantic]
  155 | QPoint GridBase::top_left() { return {x, y}; };
      |                                               ^
compilation terminated due to -Wfatal-errors.
compilation terminated due to -Wfatal-errors.
rohit-px2 commented 2 years ago

To be honest I have no idea, it's been compiling fine for me (Windows, Clang) and on the actions. They're also using Clang. Should be fixed now though (though I don't know if there are any other issues, let me know if there are).

tex commented 2 years ago

Thanks! I used GCC to compile it.

tex commented 2 years ago

@rohit-px2 Can you add install target to the build process please?

phase `check' succeeded after 0.7 seconds
starting phase `install'
make: *** No rule to make target 'install'.  Stop.
error: in phase 'install': uncaught exception:
rohit-px2 commented 2 years ago

I can try, I would have to look into how to do it first since I'm not that familiar with the install target. Also since nvui needs folders for assets and the Vimscript, I might have to make some changes there to get it working as a single executable. (Without those folders it runs fine, but there won't be any commands/images). It's definitely possible but will take some time.

tex commented 2 years ago

Sure, thanks!