rohit0718 / pe

0 stars 0 forks source link

Only multiples of 5 is allowed for cents #19

Open rohit0718 opened 2 years ago

rohit0718 commented 2 years ago

It is unclear why only multiples of 5 cents are allowed for the cents. It is possible that the tutor has a hourly rate that is does not have a perfect multiple of 5 cents. This would lead to these tutors over or undercharging the tutees unnecessarily. Might want to explicitly state in the guides why such a decision was made.

image.png

nus-pe-bot commented 2 years ago

Team's Response

"It is possible that the tutor has a hourly rate that is does not have a perfect multiple of 5 cents"

"Might want to explicitly state in the guides why such a decision was made."

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: "It does not make sense for a tutor to have an hourly rate that does not have a perfect multiple of 5 cents". I disagree with this statement. Nowadays, with the advent of online tuition, it has become easy to hire tutors from overseas countries like Malaysia. A common rate for Malaysian tutors is 100 Ringgits which translates to 32.53 Singapore dollars at the current rate. Besides, it is unfair for the product to be making assumptions about the user like "it only introduces more trouble for them and their clients when collecting payment to get coins in small denomiations" as this is unlikely to ever be a problem with online payments.

One thing that would have helped would be to explicitly state the limited denominations of hourly rate supported by the product in the User Guide instead of assuming that it is a "common practice among tutors".


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is not a verylow bug as it is not a cosmetic issue. Instead, this affects tutors who do not have hourly rates as a perfect multiple of 5 cents.