search

rohit0718 / pe

0 stars 0 forks source link

Delete error message for index is vague #3

Open rohit0718 opened 3 years ago

rohit0718 commented 3 years ago

Delete command can have more descriptive messages. It may be unclear why the provided index is invalid. Might instead want to state that there are only X entries available and user included a number > X.

image.png

nus-pe-bot commented 2 years ago

Team's Response

Duplicate of #1761.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Addlesson error message for index is vague

The error message can be clearer and state the bounds expected for the index to the user instead.

image.png

[original: nus-cs2103-AY2122S1/pe-interim#1821] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This issue was raised in the PE-Dry Run where we indicated it as the index being out of bounds. (https://github.com/AY2122S1-CS2103T-F12-3/tp/issues/126)

However, we reverted to The tutee index provided is invalid due to the suggestions provided.

Moreover, this should not be a functionality bug as it is true that the tutee index provided is invalid.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: "This issue was raised in the PE-Dry Run where we indicated it as the index being out of bounds. However, we reverted to The tutee index provided is invalid due to the suggestions provided. " Not sure how this is relevant to the my bug. My bug talks about the command being not descriptive enough while that issue talks about the message "sound[ing] a bit jargon-y.". It seems that the team has misinterpreted my bug and has linked to an irrelevant bug from before.

I feel that the error message can indeed be more descriptive to allow the users to get a sensing about exactly which index values are valid.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is not a verylow classification as it is not a cosmetic error. This is a flaw that causes occasional inconvenience to the user when they type in an index value that is beyond the number of items in the list.