rohit0718 / pe

0 stars 0 forks source link

Only Future Payment Due Dates Allowed #8

Open rohit0718 opened 3 years ago

rohit0718 commented 3 years ago

At its current state, the application might be difficult to use for tutors already managing many tutees. An app like this is espeically targetted at tutors with many tutees, all of which payments are managed solely by the tutor.

However, if a tutor with outstanding fees from multiple tutees were to now use this application, they are unable to include any tutees with overdue payments as it does not allow any dates before the current date. This leads to them being forced to only include tutees managed in the future, which may be unappealing to them.

image.png

nus-pe-bot commented 2 years ago

Team's Response

The scenario that you have mentioned (a tutor downloading the app with existing tutees with overdue fees) is rather niche as majority of the users using this command are using it to track future payment dates and having the validity check for dates will catch genuine mistakes and input errors made by the user. If some tutors really need to set a date in the past, the tutor can simply just set the current date to track it as overdue from the next day onwards or to simply edit the JSON file in the folder.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I respectfully disagree with the statement that "a tutor downloading the app with existing tutees with overdue fees" is "niche". The point of the application is to allow tutors with a lot of tutees to manage their lessons and the payments. If a tutor has been able to manage their payments effectively without the need for the app, it is unlikely that they are going to use the application at all. However, in the current state, if we have tutors with overdue payments, they are unable to properly account for them, causing a great inconvenience.

"majority of the users using this command are using it to track future payment dates". This is an unnecessary assumption to make about the users of the application which is unjustified. It is stated no where in the User Guide that this app caters only to tutors with future payment dates. The application is being sold as general purpose solution catering to all tutors.

"having the validity check for dates will catch genuine mistakes and input errors made by the user". Not sure how limiting dates to only future dates helps in validity checks and catch mistakes by user. Limiting the scope of the feature does not translate to helping the user not make mistakes. It instead prevents the flexibility of its usage.

"the tutor can simply just set the current date to track it". This goes against the user friendliness of the application as the users will need to worry about hacky workarounds like this to use the application at all. It also inconveniences the user as they are unable to properly keep track of due dates using the application.

"simply edit the JSON file in the folder.". It is unreasonable to expect the end users to directly edit the json file for a simple functionality such as keeping track of past payment due dates. It is highly likely that the user is unfamiliar with json files at all, bringing great inconveince to them as they are unable to add past payment dates at all.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: As mentioned above, I feel that a tutor adding tutees with past overdue dates is a common occurrence. The point of the application is to allow tutors with a lot of tutees to manage their lessons and the payments. If a tutor has been able to manage their payments effectively without the need for the app, it is unlikely that they are going to use the application at all. Hence this is an issue that causes occasional inconvenience to some user. Furthermore, it causes a great inconvenience to tutors who are unable to add past due dates if they need to do so. As mentioned above, they are left to do hacky workarounds like setting the current date as the due date instead. As such, I feel that this is a bug more suited for a Medium severity level.