rohit20v / tcp_chatroom

0 stars 0 forks source link

some tips #1

Open ingconti opened 5 months ago

ingconti commented 5 months ago

1) allow to pass params to java server from cmd line, such as:

java Server -port 5555

2) allow to run a JAR

rohit20v commented 5 months ago

Added cli functionality for the port number, however I'm encountering an issue with the JAR, which is that i can't open it for some reason.

ingconti commented 5 months ago

buld form cmd line, OR try using Shade plugin :)

ingconti commented 5 months ago

you have a lot of time remaining.

ingconti commented 5 months ago

pls fix readme if implemented new beahaviour form cmd line

rohit20v commented 5 months ago

buld form cmd line, OR try using Shade plugin :)

Will try for sure, thanks for the tips and recommendations

rohit20v commented 5 months ago

buld form cmd line, OR try using Shade plugin :)

Tried using maven shade plugin, and it's building me the jar file but for some reason it's only 97kb large and when i try to open it nothing actually happens.

ingconti commented 5 months ago

After buldin using MAVEN phase "package",

PastedGraphic-1.png

You should have:

image

the JAR inside shade folder should run.

rohit20v commented 5 months ago

https://streamable.com/j2apdq I tried building with shade plugin but when I try to open it nothing just happens for some reason.

ingconti commented 5 months ago

You have another issue.. if you have TWO APPS, so 2 JAR you shill have two build target.. a real mess

that's why I suggested ONE APP!

rohit20v commented 5 months ago

I've extracted the client into a new project though and there's actually only 1 build target in the new project but for some reason built JAR file has same behaviour as the older project's one

ingconti commented 5 months ago

I teed server and it works. BUT with an error!

rohit20v commented 5 months ago

I teed server and it works. BUT with an error! On 9 Apr 2024, at 16:34, rohit @.***> wrote: I've extracted the client into a new project though and there's actually only 1 build target in the new project but for some reason built JAR file has same behaviour as the older project's one — Reply to this email directly, view it on GitHub <[#1 (comment)]

I'll try fixing it asap, thanks for the feedbacks once again, much appreciated!

rohit20v commented 5 months ago

Ok so i successfully created JAR files for both the server and the client, soon I'll make a release with JAR files included :)

ingconti commented 5 months ago

Nice work!

Now I wlll play devil's part and try win Mac :)

On 10 Apr 2024, at 14:42, rohit @.***> wrote:

Ok so i successfully created JAR files for both the server and the client, soon I'll make a release with JAR files included :)

— Reply to this email directly, view it on GitHub https://github.com/rohit20v/tcp_chatroom/issues/1#issuecomment-2047440024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA64MJ3CDAVNBHPSUPTBFRLY4UXTJAVCNFSM6AAAAABF5AKBQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXGQ2DAMBSGQ. You are receiving this because you authored the thread.

ing. Conti G. Enrico @.*** Ordine Ingegneri di Monza al n. A894 Certing MBB-2430-IT20

PIVA 02119300966
C.FISC. CNTGNR63A23M052W via Duca degli Abruzzi 29 20900 MONZA MB ITALY 0039-039-324723 www.ingconti.com Pec: @.***

CODICE DESTINATARIO KRRH6B9

rohit20v commented 5 months ago

Nice work! Now I wlll play devil's part and try win Mac :) On 10 Apr 2024, at 14:42, rohit @.> wrote: Ok so i successfully created JAR files for both the server and the client, soon I'll make a release with JAR files included :) — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA64MJ3CDAVNBHPSUPTBFRLY4UXTJAVCNFSM6AAAAABF5AKBQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXGQ2DAMBSGQ. You are receiving this because you authored the thread. ing. Conti G. Enrico @. Ordine Ingegneri di Monza al n. A894 Certing MBB-2430-IT20 PIVA 02119300966 C.FISC. CNTGNR63A23M052W via Duca degli Abruzzi 29 20900 MONZA MB ITALY 0039-039-324723 www.ingconti.com Pec: @.*** CODICE DESTINATARIO KRRH6B9

Ok, here's the release, apologies for the delay :) https://github.com/rohit20v/tcp_chatroom/releases/tag/v1.0.0-initial-tcp-chatroom

ingconti commented 5 months ago

I DO close, when fine.. not YOU! :)

rohit20v commented 5 months ago

I DO close, when fine.. not YOU! :)

My bad 😅