[Intro to iOS] Assignment 1 Rotten Tomatoes

[rohitcj]

"/cc @codepath" Hi Ben/Tim,

I completed assignment 1 and implemented the required and optional features (marked w x) below.

Thanks! Rohit

Rotten Tomatoes (raw) This is a movies app displaying box office and top rental DVDs using the Rotten Tomatoes API.

Time spent: 14 Features

Required [x] User can view a list of movies. Poster images load asynchronously. [x] User can view movie details by tapping on a cell. [x] User sees loading state while waiting for the API. [x] User sees error message when there is a network error: http://cl.ly/image/1l1L3M460c3C [x] User can pull to refresh the movie list.

Optional [x] Add a tab bar for Box Office and DVD. [ ] Implement segmented control to switch between list view and grid view. [x] Add a search bar. [x] All images fade in. [x] For the large poster, load the low-res image first, switch to high-res when complete. [ ] Customize the highlight and selection effect of the cell. [x] Customize the navigation bar.

[codepathreview]

Hey Rohit! Could you make sure to follow the submission README template (http://courses.codepath.com/courses/intro_to_ios/pages/rotten_tomatoes_readme)? We were able to find the GIF in the repo but for future assignments, make sure to link to it in the project README :)

[rohitcj]

Sorry, my bad, thanks for letting me know, I will do so for future assignments. I made a few updates + bug fixes to the assignment and synced the code + updated the gif (also attached).

Thanks! Rohit

On Mon, May 11, 2015 at 10:29 AM, CodePath Reviewers < notifications@github.com> wrote:

Hey Rohit! Could you make sure to follow the submission README template ( http://courses.codepath.com/courses/intro_to_ios/pages/rotten_tomatoes_readme)? We were able to find the GIF in the repo but for future assignments, make sure to link to it in the project README :)

— Reply to this email directly or view it on GitHub https://github.com/rohitcj/RottenTomatoes/issues/1#issuecomment-100986378 .

[codepathreview]

:+1: Nice work! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

• As a reminder, there are two great style guides in the Swift community. Ray Wenderlich's Swift Style Guide and the Github Swift Style Guide
• You can remove generated Xcode functions, if not in use (e.g. https://github.com/rohitcj/RottenTomatoes/blob/a996faf3ee1c369668a8f0d6327c6639e0b6ca8e/RottenTomatoes/MovieDetailsViewController.swift#L67-L70)
• You should always try to minimize the number of properties and methods that are public or internal (access is internal by default). Make the access private if the property or function doesn't need to be accessed outside the class.
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response.
• Nice work with the custom Movie cell and encapsulating it so that it can configure itself based on the movie instance.
• Nice work loading the images asynchronously.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Nice work implementing the error message on network failure.
  • Great use of NSNotificationCenter in NetworkHelper.swift! It's a powerful tool, but make sure to remove observers in the respective classes' deinitializer

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

Feel free to reach out, if you have any questions! I'd be glad to help! :smile:

• @jasdev