search

rohitcube / pe

0 stars 0 forks source link

resizing issues for viewincomes #13

Open rohitcube opened 9 months ago

rohitcube commented 9 months ago

image.png

Screenshot 2023-11-17 at 4.38.50 PM.png

viewIncomes has trouble adjusting to user's resizing of the window. Cannot clearly see the timetable without a big screen,, incompatible to users with a smaller svreen. No mention about this in the UG>.

nus-pe-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Table is not well formatted when the console window is small

Steps to reproduce:

  1. Add some income records.
  2. Run the viewIncomes command.

Expected:

  • The table fits the size of the console window. This can be done by removing extra spaces.

Actual:

  • The table is too large and some characters is pushed to the next line.

Screenshots:

image.png

image.png

[original: nus-cs2113-AY2324S1/pe-interim#889] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This issue would not happen if the application is run on full screen. Dynamic sizing is used to maintain the UI and better presentation for users.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Team is right in saying that the "issue would not happen if the application is run on full screen", but there is no guarantee that the user is using a display that is the correct size for this program. Minimally, it should be mentioned in the UG that this feature only works within the constraint that the application is run on a certain sized screen. Personally, my team had to refactor our code due the issue of resizing for large tables, as we thought it is likely looked at as a bug in most cases if the table failed to resize properly for a smaller window.
## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** This is law with the feature (resizing of the table in a smaller console) and not documentation, however the team should have mentioned the optimal display size in the documentation (UG OR DG) as well.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I would like to change the severity to HIGH. I believe the correct severity for this issue is HIGH (High: only problems that make the product almost unusable for most users should have this label). By having no specification in the UG for the correct size, and not resizing it accurately for a small console window, if the user has a smaller display, this feature becomes almost unusable.