search

rohitcube / pe

0 stars 0 forks source link

Incomplete examples #36

Open rohitcube opened 9 months ago

rohitcube commented 9 months ago

Screenshot 2023-11-17 at 5.29.10 PM.png

For these examples wouldn't it be more thorough for the user, if viewexpenses is shown as well, so user knows that the things being filtered for work?

nus-se-bot commented 9 months ago

Team's Response

Not sure what you mean here. Are you suggesting also showing the entire expense transactions along with the filtered results? The filtering function is meant to serve the purpose of allowing users to look for specific transactions instead of having to look through the entire list of all transactions, thus showing the entire expense transactions when calling the filter function would make this function pointless.

To address the issue of knowing that the filter works, "Here are your corresponding expenses with ..." is being output to reflect to the user that the filtering is being done with the specified criteria.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]