rohitdasu / projectmate

Supercharge your open-source contributions with projectmate.net; Discover open-source projects, connect with experienced maintainers, and collaborate with a community of passionate contributors. Join over 200+ registered users who are already making a difference
https://projectmate.net
MIT License
148 stars 107 forks source link

Filtering by tags #450

Closed shovonroy173 closed 2 months ago

shovonroy173 commented 3 months ago

Fixes Issue

Changes proposed

Note to reviewers

Screenshots

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
projectmate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2024 0:44am
rohitdasu commented 3 months ago

@shovonroy173 functionality works great, but there are 2 change request i would like to make.

  1. on scroll of the page, make the tags section sticky.
  2. show the selected tag, currently if i select any tag, i'm not able to know which one is selected.
shovonroy173 commented 3 months ago

Ok, I will do that.

On Sun, Mar 24, 2024, 17:05 Rohit @.***> wrote:

@shovonroy173 https://github.com/shovonroy173 functionality works great, but there are 2 change request i would like to make.

  1. on scroll of the page, make the tags section sticky.
  2. show the selected tag, currently if i select any tag, i'm not able to know which one is selected.

— Reply to this email directly, view it on GitHub https://github.com/rohitdasu/projectmate/pull/450#issuecomment-2016779609, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2EA4NMQQBCAYWZG3XWLPLYZ227DAVCNFSM6AAAAABFFRTFKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWG43TSNRQHE . You are receiving this because you were mentioned.Message ID: @.***>

shovonroy173 commented 3 months ago

@rohitdasu, check the updates, let know for any other updates

rohitdasu commented 3 months ago

@shovonroy173 could you pls fix the build issue

Screenshot 2024-03-25 at 10 32 11 PM
shovonroy173 commented 3 months ago

now Screenshot 2024-03-25 at 23-32-56 Filtering by tags by shovonroy173 · Pull Request #450 · rohitdasu_projectmate

previous Screenshot 2024-03-25 at 23-32-38 Filtering by tags by shovonroy173 · Pull Request #450 · rohitdasu_projectmate @rohitdasu , check for build issue. I will modify the double click i some time.

rohitdasu commented 3 months ago

@shovonroy173 build issue got fixed

shovonroy173 commented 3 months ago

@rohitdasu , single click deselect applied . All the updates done. Please check.

rohitdasu commented 3 months ago

@rohitdasu , single click deselect applied . All the updates done. Please check.

sure, will check and let you know.

shovonroy173 commented 3 months ago

Ok .

On Mon, Apr 1, 2024, 11:22 Rohit @.***> wrote:

@rohitdasu https://github.com/rohitdasu , single click deselect applied . All the updates done. Please check.

sure, will check and let you know.

— Reply to this email directly, view it on GitHub https://github.com/rohitdasu/projectmate/pull/450#issuecomment-2029207384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2EA4L76KROL7FG3SCSB7TY3DYZZAVCNFSM6AAAAABFFRTFKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGIYDOMZYGQ . You are receiving this because you were mentioned.Message ID: @.***>

shovonroy173 commented 3 months ago

@rohitdasu, hi sir, is everything working fine ?

rohitdasu commented 3 months ago

@rohitdasu, hi sir, is everything working fine ?

Hi @shovonroy173 its not working as expected. I did test it, when we click any tag and which is not rendered in the frontend, its not showing but its in the db. Please test it properly.

shovonroy173 commented 3 months ago

Are you saying that some tags missing ?? But , I checked the number of tags manually , even then the they are the same . In this db , all the unique tags are showing. Please suggest me how can I test it further ??

On Wed, Apr 3, 2024, 23:45 Rohit @.***> wrote:

@rohitdasu https://github.com/rohitdasu, hi sir, is everything working fine ?

Hi @shovonroy173 https://github.com/shovonroy173 its not working as expected. I did test it, when we click any tag and which is not rendered in the frontend, its not showing but its in the db. Please test it properly.

— Reply to this email directly, view it on GitHub https://github.com/rohitdasu/projectmate/pull/450#issuecomment-2035283798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2EA4OLCKXJ2DVWYLXRO6LY3RBL5AVCNFSM6AAAAABFFRTFKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGI4DGNZZHA . You are receiving this because you were mentioned.Message ID: @.***>

rohitdasu commented 3 months ago

Visit Preview

this is one of the examples, I've clicked javascript tag - but it's showing no data. please filter projects in the backend so it will display all projects according to the tag.

Screenshot 2024-04-04 at 11 38 04 AM
shovonroy173 commented 2 months ago

sorry for being late , but working on it

shovonroy173 commented 2 months ago

where: { tags: { hasEvery: tag, mode: 'insensitive' }, }, "hasEvery" take only string | string[] , when i add (mode: 'insensitive') , showing this error "Object literal may only specify known properties, and 'mode' does not exist in type 'StringNullableListFilter'." As it is predefined to type StringNullableListFilter { equals?: List | Null has?: String | Null hasEvery?: List hasSome?: List isEmpty?: Boolean } @rohitdasu sir , what to do now. I have applied several methods, searched through the documentation , none of them worked.

rohitdasu commented 2 months ago

where: { tags: { hasEvery: tag, mode: 'insensitive' }, }, "hasEvery" take only string | string[] , when i add (mode: 'insensitive') , showing this error "Object literal may only specify known properties, and 'mode' does not exist in type 'StringNullableListFilter'." As it is predefined to type StringNullableListFilter { equals?: List | Null has?: String | Null hasEvery?: List hasSome?: List isEmpty?: Boolean } @rohitdasu sir , what to do now. I have applied several methods, searched through the documentation , none of them worked.

no problem. let me handle this. thanks for contributing :)

shovonroy173 commented 2 months ago

Thank you for giving me my first opensource project. It's a pleasure to working with you.

On Wed, Apr 10, 2024 at 5:03 PM Rohit @.***> wrote:

Merged #450 https://github.com/rohitdasu/projectmate/pull/450 into main.

— Reply to this email directly, view it on GitHub https://github.com/rohitdasu/projectmate/pull/450#event-12420465305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2EA4MUCA3XXUKMEI5OP4LY4UPQVAVCNFSM6AAAAABFFRTFKSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGQZDANBWGUZTANI . You are receiving this because you were mentioned.Message ID: @.***>

rohitdasu commented 2 months ago

You're welcome :)

Best of luck with your new open-source adventure.