Why do the parameters in $attributes and prompts. yaml need to be concatenated with ' ' instead of: ","

rohitgandikota / sliders

Concept Sliders for Precise Control of Diffusion Models

https://sliders.baulab.info

MIT License

977 stars 78 forks source link

Why do the parameters in $attributes and prompts. yaml need to be concatenated with ' ' instead of: "," #99

Open benzhangdragonplus opened 4 months ago

benzhangdragonplus commented 4 months ago

file location：trainscripts/imagesliders/promptutil.py row 163-167： copy['target'] = att + ' ' + copy['target'] copy['positive'] = att + ' ' + copy['positive'] copy['neutral'] = att + ' ' + copy['neutral'] copy['unconditional'] = att + ' ' + copy_['unconditional']

Why do $attributes need to be concatenated with ' ' for all parameters? Will this not be considered as the same set of prompt words as the following prompt words? Should ' ,' not be used for concatenation?

rohitgandikota commented 4 months ago

Hi, thanks for the question! I dont think we have looked into different ways to concatenate the attributes to the original prompts. This was a design choice to use ' ' instead of a ','

Please let us know if you have observed any significant performance improvements or changes when using a comma instead. Would be happy to integrate the change to the code