rohithill / nithp

View NITH result live.
https://nithp.herokuapp.com/
7 stars 7 forks source link

increase pagination max-limit to 150. #5

Closed RohitKaushal7 closed 4 years ago

RohitKaushal7 commented 4 years ago

please increase pagination limit to 150, as now there are usually more then 100 students in one class so it would need two fetch requests to the API to fetch the result of 105 students. which could have been done in one.

api/result/student?branch=cse&roll=18%&limit=150

also can there be an api endpoint to fetch the results of a class like.. api/result/student?branch=cse&year=2018

current hack is.. api/result/student?branch=cse&roll=18%

which works perfectly fine but.

RohitKaushal7 commented 4 years ago

Actually can we make it around 3000. :)

I mean what if someone needs whole data college data in 1 request.. otherwise it needs 30 requests again and again which is very slow.. :smile:

rohithill commented 4 years ago

I have updated the limit to 1000.