search

rohitk-singh / WhatsApp-Square-DP

Python script to create Square DP Images for use with WhatsApp
GNU General Public License v3.0
1 stars 1 forks source link

Added portrait mode support #10

Closed piymis closed 7 years ago

piymis commented 7 years ago

9

rohitk-singh commented 7 years ago

Nice! We should also in future probably have tests for checking correctness of both landscape and portrait modes. https://github.com/recurser/exif-orientation-examples http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/

piymis commented 7 years ago

Good idea. Need to create a bunch of unit test cases maybe?

rohitk-singh commented 7 years ago

Yeah. It would be important thing to implement. We can then trigger the tests using CI. Please create an issue for this, which we can fix later.