search

rohitk-singh / WhatsApp-Square-DP

Python script to create Square DP Images for use with WhatsApp
GNU General Public License v3.0
1 stars 1 forks source link

Add tests for portrait and landscape images #11

Open piymis opened 7 years ago

piymis commented 7 years ago

Tests for checking correctness of both landscape and portrait modes. https://github.com/recurser/exif-orientation-examples http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/ We can then trigger the tests using CI.

piymis commented 7 years ago

@rohitk-singh by CI, did you mean continuous integration or command interface?

rohitk-singh commented 7 years ago

@piymis I meant continuous integration. We can run the test suite after every commit to make sure it doesn't break existing functionality

piymis commented 7 years ago

Cool. Do you have something in mind for CI?

rohitk-singh commented 7 years ago

Travis CI would do fine. I've enabled CI for this repo on Travis. Let me check if I can get it working

rohitk-singh commented 7 years ago

Update: We now have TravisCI configured at https://travis-ci.org/rohitk-singh/WhatsApp-Square-DP All commits and merge requests can now be checked for regression and build tests. Build status would also appear besides commits https://github.com/rohitk-singh/WhatsApp-Square-DP/commits/master

piymis commented 7 years ago

Cool! Mind adding few positive and negative unit tests?

rohitk-singh commented 7 years ago

Yeah please do add some. We should probably use pytest/unittest/nose for the tests.

piymis commented 7 years ago

Okay let me take a look and come back within a day or two.

rohitk-singh commented 7 years ago

Sure! Meanwhile I'll add some if I can figure out how to do that.