search

rohitrango / objects-that-sound

Unofficial Implementation of Google Deepmind's paper `Objects that Sound`
83 stars 16 forks source link

ffmpeg - a pre-requisite to download #2

Closed ShilpaSangappa closed 5 years ago

ShilpaSangappa commented 5 years ago

Hi Rohit,

ffmpeg could be listed out as a pre-requisite to download and split, using the file get_video_audio.py.

Exit status of the subprocess which runs ffmpeg to extract audio and video is not captured and hence it took some time to figure out that ffmpeg not being installed in the system was the issue.

With Regards, Shilpa

rohitrango commented 5 years ago

Hi Shilpa,

Sorry I missed out on the issue. Can you submit a small PR correcting the change if you have some time?

Thanks

ShilpaSangappa commented 5 years ago

Sure. Will do. I am on vacation and will be back to lab on Wednesday.

Thanks.

On Sun, 10 Feb 2019 13:35 Rohit Kumar Jena <notifications@github.com wrote:

Hi Shilpa,

Sorry I missed out on the issue. Can you submit a small PR correcting the change if you have some time?

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rohitrango/objects-that-sound/issues/2#issuecomment-462112246, or mute the thread https://github.com/notifications/unsubscribe-auth/ACEqPRsvHnQZUCAzNjKS6Dwd4YHZejsiks5vL9K5gaJpZM4aL7wl .

rohitrango commented 5 years ago

Thank you. Have fun on your vacation :)