rohitsax / gwt-phonegap

Automatically exported from code.google.com/p/gwt-phonegap
0 stars 0 forks source link

reduce permutations #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
We can restrict the phonegap.env property to the case of user-agent is safari. 

Maybe we could add ie for window mobiles, but I've not played with any of this 
devices yet.

Attached patch.

- Manolo

Original issue reported on code.google.com by manuel.carrasco.m on 13 Jul 2012 at 12:05

Attachments:

GoogleCodeExporter commented 9 years ago
same argument than on the mgwt issue tracker: 
http://code.google.com/p/mgwt/issues/detail?id=215

Original comment by kurka.da...@gmail.com on 13 Jul 2012 at 2:34

GoogleCodeExporter commented 9 years ago
In this case we don't remove the property, so we will produce permutations for 
any kind of browsers based on safari. What we eliminate are permutations of the 
kind of:
phonegap.env=yes user.agent=ie6
phonegap.env=yes user.agent=gecko1_8

which makes no sense at all.

But we will continue having sensitive things like 
phonegap.env=no user.agent=ie6
phonegap.env=no user.agent=gecko1_8
phonegap.env=no user.agent=safari
phonegap.env=yes user.agent=safari

Original comment by manuel.carrasco.m on 13 Jul 2012 at 5:16

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 1b7c6206194b.

Original comment by kurka.da...@gmail.com on 14 Jul 2012 at 11:51

GoogleCodeExporter commented 9 years ago
changes in trunk, part of next release

Original comment by kurka.da...@gmail.com on 14 Jul 2012 at 11:51

GoogleCodeExporter commented 9 years ago

Original comment by kurka.da...@gmail.com on 23 Sep 2012 at 7:40