search

rohitvarkey / ThreeJS.jl

Julia interface to WebGL using Three-js custom elements and Patchwork.jl
https://rohitvarkey.github.io/ThreeJS.jl
Other
56 stars 15 forks source link

[wip] mesh loading example #12

Closed sjkelly closed 8 years ago

sjkelly commented 8 years ago

I noticed the geometry function was added and I was curious if it could be made to work with the HomogenousMesh type in GeometryTypes. The conversion is not nearly generic enough to work on all supported geometries. This is WIP since I have the following questions: Would it make sense to provide some conversions from GeometryTypes in this package? The my naive attempt at eventing doesn't seem to work.

codecov-io commented 8 years ago

Current coverage is 95.16%

Merging #12 into master will not affect coverage as of 0d63bf3

@@            master     #12   diff @@
======================================
  Files            3       3       
  Stmts           62      62       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             59      59       
  Partial          0       0       
  Missed           3       3

Review entire Coverage Diff as of 0d63bf3

Powered by Codecov. Updated on successful CI builds.

rohitvarkey commented 8 years ago

Sorry for the late reply!

This is really cool and what I wanted to accomplish when I saw your ThreeJS mesh too. :smile: This works nicely for me, except that the sliders don't seem to update the geometry (is that what you meant by eventing?). I will look into that soon. But being able to actually load .obj files and showing actual objects like that cat is really awesome!

I think having conversions from GeomertyTypes would be useful with respect to the whole Julia graphics ecosystem and getting everything to work nicely together.

sjkelly commented 8 years ago

Thanks! You are right, by "eventing" I mean updating the geometry. It is good to hear we could bring some GeometryTypes definitions in here. In the meantime I will work on that until the update issues get sorted out.

rohitvarkey commented 8 years ago

@sjkelly I've got "eventing" working for geometry now. :smile: #14 has fixed the update problems. Your example works fine for me now.

scale_cat

Would you mind getting rid of the other commits except for e2198906c5f80f415b029e47304478f2ff539887? That fix didn't work anyway. :)

Thanks again!

sjkelly commented 8 years ago

Sweet! I rebased this and moved the AbstractMesh->geometry function into the package. This now adds a dependency on GeometryTypes.

rohitvarkey commented 8 years ago

Thanks again! :smile: