search

rohitvarkey / ThreeJS.jl

Julia interface to WebGL using Three-js custom elements and Patchwork.jl
https://rohitvarkey.github.io/ThreeJS.jl
Other
56 stars 15 forks source link

[WIP] WebGL shader material and data texture #33

Closed izaid closed 8 years ago

izaid commented 8 years ago

This extends the WebGL interface of ThreeJS.jl by adding Julia functions for ShaderMaterial and DataTexture from ThreeJS. This allows pretty much arbitrary WebGL shaders to be attached to meshes.

It requires some changes in Patchwork.jl and Escher.jl, which have yet to be merged there.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling cd959b107941ac3bf0f7685f64e353b3f4377085 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling cd959b107941ac3bf0f7685f64e353b3f4377085 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling cd959b107941ac3bf0f7685f64e353b3f4377085 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

codecov-io commented 8 years ago

Current coverage is 89.88% (diff: 0.00%)

Merging #33 into master will decrease coverage by 3.13%

@@             master        #33   diff @@
==========================================
  Files             3          3          
  Lines            86         89     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             80         80          
- Misses            6          9     +3   
  Partials          0          0

Powered by Codecov. Last update 2104c34...f426346

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling 23f3e18f5343c353cefb13a86e45aa7b4db98935 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling 23f3e18f5343c353cefb13a86e45aa7b4db98935 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-4.7%) to 88.35% when pulling 4f27f7312ec62cde082945dc303e60948b15dfe4 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

rohitvarkey commented 8 years ago

I have actually seperated out the three-js elements to this repository - https://github.com/rohitvarkey/three-js. It'd be great if you can make a PR for just the Polymer parts there, and do a bower update and then update the elements here.

Otherwise, this looks good so far. Thanks @izaid for the effort!

Also, can you push the Escher and Patchwork changes to a branch somewhere so I can test this?

izaid commented 8 years ago

Will do!

You can get the Patchwork.jl repo from https://github.com/izaid/Patchwork.jl/tree/hooks and the Escher.jl repo from https://github.com/izaid/Escher.jl/tree/nested-props

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-4.7%) to 88.35% when pulling f1440444a9d1a00fd2e8d0bbb4b116e17a21a870 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-4.7%) to 88.35% when pulling f1440444a9d1a00fd2e8d0bbb4b116e17a21a870 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-4.7%) to 88.35% when pulling f1440444a9d1a00fd2e8d0bbb4b116e17a21a870 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-4.7%) to 88.35% when pulling f1440444a9d1a00fd2e8d0bbb4b116e17a21a870 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-4.7%) to 88.35% when pulling f1440444a9d1a00fd2e8d0bbb4b116e17a21a870 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling 570f76d15131ccd744bb2af399c99e75ba2f98ca on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling 570f76d15131ccd744bb2af399c99e75ba2f98ca on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling 570f76d15131ccd744bb2af399c99e75ba2f98ca on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

shashi commented 8 years ago

Nice!

@rohitvarkey would this work in Jupyter? The escher-prop-hook thing comes from Escher/assets...

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling f4263466b539e781bbae8ab0b8a5c4f5884e7f85 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling f4263466b539e781bbae8ab0b8a5c4f5884e7f85 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling f4263466b539e781bbae8ab0b8a5c4f5884e7f85 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling f4263466b539e781bbae8ab0b8a5c4f5884e7f85 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling f4263466b539e781bbae8ab0b8a5c4f5884e7f85 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.1%) to 89.888% when pulling f4263466b539e781bbae8ab0b8a5c4f5884e7f85 on izaid:shadermaterial into 2104c34b5b9504637c9d231c2c05020007742eae on rohitvarkey:master.

izaid commented 8 years ago

@rohitvarkey Can I just confirm that you are okay with the fact that this works via Escher (as @shashi mentioned) and thus we're not sure if it will work in Jupyter? When you confirm that, I'll go ahead and reopen this PR with the bower update separate.

rohitvarkey commented 8 years ago

would this work in Jupyter? The escher-prop-hook thing comes from Escher/assets

Nope. It wouldn't work. Unless we figure out how to serve those files in Jupyter.

Can I just confirm that you are okay with the fact that this works via Escher

I'm okay with this.

izaid commented 8 years ago

Alright, I'm closing this and will reopen two separate PRs.