search

rohitvarkey / ThreeJS.jl

Julia interface to WebGL using Three-js custom elements and Patchwork.jl
https://rohitvarkey.github.io/ThreeJS.jl
Other
56 stars 15 forks source link

three-js as a Git subrepository? #36

Closed izaid closed 7 years ago

izaid commented 7 years ago

So, I'm just trying to optimize my workflow for making PRs to ThreeJS.jl. Is there a good way to edit branches of three-js and ThreeJS.jl at the same time? If not, maybe we should add three-js as a Git subrepository here?

rohitvarkey commented 7 years ago

Setting three-js as a submodule would make things easier to work with. Can you come up a PR to do so?

izaid commented 7 years ago

Yeah, I can do it. I'm just thinking about it atm though. This may interact badly with Julia's package manager, which doesn't handle subrepositories.

rohitvarkey commented 7 years ago

This may interact badly with Julia's package manager, which doesn't handle subrepositories.

In that case, sticking with the current approach would be a better option I feel.

izaid commented 7 years ago

Fixed this now.