Overwrites Gravity Forms settings

[Surbma]

Hi,

thank you for your work and this free sharing to use your plugin!

I'm testing your plugin on my Multisite install. It is working well.

I'm using Gravity Forms on my sites. There is an option in Gravity Forms to create notifications with the options to set sender email, sender name. Your plugin's settings will overwrite Gravity Forms settings, so even if I set a different email there, your plugin's settings will be used to send out the notification, which is not good.

I was using the wp-mail-smtp plugin before your plugin. It was working with Gravity Forms well, so the default settings were the wp-mail-smtp's settings, but Gravity Forms settings overwrote them. It was the right way to do it.

So my question is if you can fix this in your plugin to let other plugins to overwrite the default settings of your plugin. In a Multisite install this feature is essential.

Thank you!

[rohmann]

Hi Peter,

Thanks for brining this up! I'll take a look at it later today and see what I can come up with. At a glance at the code, I see why this would be happening - it's probably affecting more than gravity forms. I'll just need to find a way to give per site activated plugins precedance.

-Alexander On October 6, 2013 at 10:58:11 AM, Peter Ambrus (notifications@github.com) wrote:

Hi,

thank you for your work and this free sharing to use your plugin!

I'm testing your plugin on my Multisite install. It is working well.

I'm using Gravity Forms on my sites. There is an option in Gravity Forms to create notifications with the options to set sender email, sender name. Your plugin's settings will overwrite Gravity Forms settings, so even if I set a different email there, your plugin's settings will be used to send out the notification, which is not good.

I was using the wp-mail-smtp plugin before your plugin. It was working with Gravity Forms well, so the default settings were the wp-mail-smtp's settings, but Gravity Forms settings overwrote them. It was the right way to do it.

So my question is if you can fix this in your plugin to let other plugins to overwrite the default settings of your plugin. In a Multisite install this feature is essential.

Thank you!

— Reply to this email directly or view it on GitHub.

[Surbma]

Great! Thank you! I'm glad, that you support and develop this plugin.

[rohmann]

For now, you can resolve this on your site by commenting out the lines that assign the From address and name.

//$phpmailer->From = GLOBAL_SMTP_FROM;
//$phpmailer->FromName = GLOBAL_SMTP_FROM_NAME;

I'll add options to allow these to be set earlier which would allow other plugins to override the headers. But I'll also leave it so they can be forced globally. (for branding purposes etc.)

[Surbma]

I'll test it out. Thank you for the quick fix!

It totally makes sense to let network administrators choose to use the global settings only or let individual sites to override this setting. In my case I have to let all sites to have their own settings, as I'm managing my clients in my Multisite install, so every sub site is a different site.

I will let you know, if this fix is working for me.

[Surbma]

I have modified the code as you wrote and it seems everything is working. :)

[rohmann]

Thanks for confirming! I'll fix this in the next release, along with a few minor improvements.

[Surbma]

When do you want to release the next version? Do you want to continue developing this plugin?

[Surbma]

It seems in the new 2.0 version everything is working as expected. Congratulation @rohmann and thank you for the plugin and all your time spending to develop and maintain this plugin.