search

roidrage / lograge

An attempt to tame Rails' default policy to log everything.
http://www.paperplanes.de/2012/3/14/on-notifications-logsubscribers-and-bringing-sanity-to-rails-logging.html
MIT License
3.47k stars 300 forks source link

Ability to disable ActionCable MonkeyPatch #294

Open jwhitcraft opened 5 years ago

jwhitcraft commented 5 years ago

We are using this gem currently, but we want to migrate away from ActionCable in-favor of AnyCable, but when this gem it doesn't allow us to since AnyCable uses a custom ActionCable::Connection::Base class found here which has a custom handle_open and handle_close. Would it be possible to provide a way to disable ActionCable Logging?

Thanks.

georgepalmer commented 5 years ago

As another use case for the ability to disable action cable integration we run a separate cable server and the default Rails logs are much more verbose. For example we get "unauthorized connection attempt" events which don't seem to come through with this. I know this isn't your fault and the logging in ActionCable is a mess, but it'd be great if we could use lograge on our main app and keep the Rails default on the ActionCable server.

Additionally IP address isn't available in the ActionCable logs which is a critical one for us as we want to know IPs when there are bad actors

uhrohraggy commented 3 years ago

FYI - this is still an issue today. https://github.com/roidrage/lograge/issues/304 appears to address this fully (not splitting up log handlers but allowing lograge to work with both main app and action cable/anycable)

rromanchuk commented 2 years ago

@georgepalmer have you successfully monkey patched the monkey patch out of your system? I need to isolate and reduce complexity because i'm spending too much time on this.

After updating to latest anycable, sentry, lograge, rails 7 i'm now imploding here

wrong number of arguments (given 1, expected 0)
lograge (bf6954566607) lib/lograge/rails_ext/action_cable/channel/base.rb in subscribe_to_channel at line 6
iloveitaly commented 2 years ago

@rromanchuk have you tried the master version? This should be fixed on master.

rromanchuk commented 2 years ago

@iloveitaly reverting back to palkan/lograge fixed it, I probably only had roidrage/lograge thinking it was already tagged. I'll try again later

iloveitaly commented 2 years ago

@rromanchuk roidrage/lograge should contain the fix for this (https://github.com/roidrage/lograge/commit/2fd03f78a78bc0d964fd48d281126a4cd58c7d79). Is roidrage/lograge master not working for you? What error are you running into?