search

roidrage / redis-session-store

A simple session store for Rails based on Redis.
http://github.com/roidrage/redis-session-store
MIT License
366 stars 147 forks source link

Decode sesssion with_indifferent_access if defined ActiveSupport #102

Closed iggant closed 6 years ago

iggant commented 6 years ago

Inspire by https://github.com/roidrage/redis-session-store/issues/71

We are moving from active_record_store to redis_session_store

but we already everywhere use key to access session, so we need this fix

Jesterovskiy commented 6 years ago

https://github.com/roidrage/redis-session-store/pull/60 @daniel-g @meatballhat I saw this PR and what do you say about @iggant patch? I think this is ok, if someone use ActiveSupport, get with_indifferent_access method. What do you think?

daniel-g commented 6 years ago

it seems fine on my side, I would just add a text in the documentation about this possibility, maybe a "Rails" section.

iggant commented 6 years ago

@Jesterovskiy made rubocop fixes and changes