search

roidrage / redis-session-store

A simple session store for Rails based on Redis.
http://github.com/roidrage/redis-session-store
MIT License
366 stars 147 forks source link

Not working with rack 2.0.8 #116

Closed fabn closed 4 years ago

fabn commented 4 years ago

I've updated to rack 2.0.8 because of CVE-2019-16782 but my application has problems and raise an error with that version of rack when accessing sidekiq interface.

Here's the involved rack commit https://github.com/rack/rack/commit/7fecaee81f59926b6e1913511c90650e76673b38

And I get an error coming from this line that calls this line

majksner commented 4 years ago

New Rack 2.1.1 was released that fixes this issue with https://github.com/rack/rack/pull/1462

Jesterovskiy commented 4 years ago

Nice to hear that, I'll close this issue

majksner commented 4 years ago

I'm still getting error, this time different one when accessing Sidekiq UI.

Screen Shot 2020-01-13 at 09 18 50

Jesterovskiy commented 4 years ago

@majksner strange, I see this in 2.1.1 release https://github.com/rack/rack/commit/8659d9f073c79dac9ddd7ab84b8e647a1ad4d34e

majksner commented 4 years ago

@jessedoyle Yes, but that's in the master, not yet released. 2.1.1 tag doesn't have that fix.

https://github.com/rack/rack/blob/2.1.1/lib/rack/session/abstract/id.rb

Jesterovskiy commented 4 years ago

You right) you can use master branch then and wait for release with fixes