search

roidrage / redis-session-store

A simple session store for Rails based on Redis.
http://github.com/roidrage/redis-session-store
MIT License
366 stars 147 forks source link

Make redis-session-store compatible with redis 5 #136

Closed sgara closed 1 year ago

Jesterovskiy commented 1 year ago

Sorry, I'll close PR because of https://github.com/roidrage/redis-session-store/pull/137

leastbad commented 1 year ago

FWIW, this PR would have immediately broken the gem.

I suspect that the maintainers have to balance their tone, but I have no such constraint: this might have had good intentions, but moves like this make open source less good.

Do you really think that, with all of the folks who use this library, that nobody had gotten around to just incrementing a version number?

Major versions in SemVer mean breaking changes. In this case, those changes broke 0.11.4.

At least run the code next time. Maybe even the test suite?

Not mad; just disappointed. If someone had merged this, and it broke production applications, it would have killed the reputation of the project.