search

roidrage / redis-session-store

A simple session store for Rails based on Redis.
http://github.com/roidrage/redis-session-store
MIT License
366 stars 147 forks source link

support for redis-rb v5 #137

Closed leastbad closed 1 year ago

leastbad commented 1 year ago

Add support for redis-rb v5.

Passes all cops and specs.

The primary consideration for v5 is that we cannot pass invalid config options to the Redis gem going forward. This means that :expire_after and :key_prefix need to be removed from the options hash before it is passed to Redis.new.

I apologize for the janky code and seemingly pointless variable rename. The project is configured to accept 10 lines per method and 100 characters per line. The method was 9 lines when I got to it, and line 45 is exactly 100 characters long.

Nobody is asking for my opinion on these constraints, so I'll leave it to you if you want to guess. 😉

Closes #135

Jesterovskiy commented 1 year ago

LGTM 👍 Good job!

leastbad commented 1 year ago

@Jesterovskiy @olleolleolle @roidrage @iancanderson all we want for Christmas/Thanksgiving/our birthday is a redis-session-store release cut that supports redis-rb v5, since this gem is now breaking when someone uses rails new.

Is there a charity I could donate to which would wake the dragon so we can get this done?

I'm sorry for being 2/10 obnoxious - it's against my nature - but there's a growing urgency. It's an actual blocker for the next major release of our framework.

Jesterovskiy commented 1 year ago

@leastbad done, sorry for the big delay)

leastbad commented 1 year ago

Thank you!