Open hogelog opened 1 year ago
The current redis-session-store has been implemented to throw the exists command to redis twice. https://github.com/roidrage/redis-session-store/blob/21c576d5460f38ee781037114ec22f354c453828/lib/redis-session-store.rb#L68 https://github.com/roidrage/redis-session-store/blob/21c576d5460f38ee781037114ec22f354c453828/lib/redis-session-store.rb#L124
With this PR implementation, a session that has not been migrated to private_id will throw get commands to private_id and public_id twice. But migrated session will only get once, which I think is more efficient.
The current redis-session-store has been implemented to throw the exists command to redis twice. https://github.com/roidrage/redis-session-store/blob/21c576d5460f38ee781037114ec22f354c453828/lib/redis-session-store.rb#L68 https://github.com/roidrage/redis-session-store/blob/21c576d5460f38ee781037114ec22f354c453828/lib/redis-session-store.rb#L124
With this PR implementation, a session that has not been migrated to private_id will throw get commands to private_id and public_id twice. But migrated session will only get once, which I think is more efficient.