Custom encoder class

[dplummer]

This adds a configuration option for the encoder class to use. In Rails 4, this allows the use of MultiJson for the encoder:

My::Application.config.session_store = :redis_session_store, {
  :key          => 'your_session_key',
  :encoder_class => MultiJson
}

[dplummer]

It probably isn't a good idea to use MultiJson for the encoder in rails 3 because I think the FlashHash implementation doesn't serialize as json well.

Oh, maybe I should name the key serializer instead of encoder_class. What do you think?

[meatballhat]

I prefer serializer, yup.

[meatballhat]

@dplummer Did you happen to check if there's a precedent for this, perhaps in the Dalli session store?

[dplummer]

Excellent question. I looked through the source of dalli and rails' memcache store and I don't see how it marshal's it. I'll keep looking.

[meatballhat]

@dplummer don't sweat it! I was mostly just curious :smiley_cat:

[dplummer]

Thanks for asking about precedent. I tracked down rails issue #13692, which adds similar behavior to the built-in cookie store. Hold up on merging this PR, I want to review what @lukesarnacki did and support the same interface.

[lukesarnacki]

Hi @dplummer, this was actually rewritten so you will probably have better luck looking at this one rails/rails#13945

[meatballhat]

@dplummer sorry about the conflicts! :scream_cat:

[dplummer]

Alright, so I rewrote it to allow you to specify the serializer as :marshal, :json, or :hybrid. :marshal is default.

I'm requiring json. I'm not sure if that's the right thing to do, but I don't know what else to do here.

[meatballhat]

@dplummer you get a chance to look at the conflicts yet?

[dplummer]

Thanks for the bump, I've rebased on master.

[meatballhat]

@dplummer yay!