search

roidrage / redis-session-store

A simple session store for Rails based on Redis.
http://github.com/roidrage/redis-session-store
MIT License
366 stars 147 forks source link

Allow Separate Store Session Expiration Option #85

Open mullen3 opened 7 years ago

mullen3 commented 7 years ago

This pull request adds an option that allows you to specify a separate timeout for the expiration of the session in redis than the expiration set on the cookie. This flexibility allows you to use a transient cookie that still expires if the browser is left open.

I have also added a few specs for the different expiration scenarios.

mullen3 commented 7 years ago

Ah it looks like a similar feature was proposed in #84. Do the maintainers have a preference between the two options and implementations?

mullen3 commented 7 years ago

@roidrage @meatballhat Friendly bump. I'm happy to fix the RuboCop style issues if the maintainers have interest in this feature.