search

roidrage / redis-session-store

A simple session store for Rails based on Redis.
http://github.com/roidrage/redis-session-store
MIT License
366 stars 147 forks source link

Update Actionpack version to include all patches for 5.1 #91

Closed Jesterovskiy closed 7 years ago

Jesterovskiy commented 7 years ago

@meatballhat Do I need fix RuboCop issues? Because he broken build.

jpawlyn commented 7 years ago

@Jesterovskiy FYI I've added a PR to fix the RuboCop issues https://github.com/roidrage/redis-session-store/pull/92

jpawlyn commented 7 years ago

@Jesterovskiy The PR to fix RuboCop issues has been merged so hopefully if you rebase against master, this PR should be green 🤞 🙇

Jesterovskiy commented 7 years ago

@jpawlyn Done!

Jesterovskiy commented 7 years ago

@roidrage your turn =)

nimashariatian commented 7 years ago

awesome, can this be merged and make a new release?

nicubucalaete commented 7 years ago

I also need these changes in order to migrate a project to Rails 5.1

nimashariatian commented 7 years ago

@jpawlyn can you check out this PR please? :)

jpawlyn commented 7 years ago

@nimashariatian I think we probably want one of the gem owners to take a look. They can hopefully merge the PR and release a new version. If you have a moment please... @meatballhat @dplummer @iancanderson 😃

nimashariatian commented 7 years ago

oh thanks for the update @jpawlyn !

samcday commented 7 years ago

Bump! We need a new release of redis-session-store so we can move to Rails 5.1 please :)

nimashariatian commented 7 years ago

yes and then we can all party? lol

attenzione commented 7 years ago

seems it's not going to work, because i'm getting error:

Gem Load Error is: uninitialized constant Rack::Session::Abstract::ENV_SESSION_OPTIONS_KEY
Backtrace for gem load error is:
/lib/redis-session-store.rb:10:in `<class:RedisSessionStore>'
nimashariatian commented 7 years ago

that's because this PR hasn't been merged yet @attenzione. you can point your gem to this PR like so: gem 'redis-session-store', git: "https://github.com/CapCap/redis-session-store"

attenzione commented 7 years ago

this PR will not fix issue with Rack::Session::Abstract::ENV_SESSION_OPTIONS_KEY, see "Files changed".

CapCap/redis-session-store is another fork with fix, but this PR is another

nimashariatian commented 7 years ago

oh you're right, was looking at the wrong PR

samcday commented 7 years ago

Hey @Jesterovskiy thanks for getting this PR up and then merging it. Will a new release of them gem to Rubygems.org be coming soon?

Jesterovskiy commented 7 years ago

@samcday I don't have rights to release on rubygems. @roidrage can you help with this?