roidrole / A-Dark-Mode

Reskins minecraft and some mods to a dark mode
0 stars 0 forks source link

Mods Looking for Support #10

Open WaitingIdly opened 1 month ago

WaitingIdly commented 1 month ago

identified a large number of GUIs that are not currently supported by this texture pack. each link either goes directly to the texture looking for support (if there is only one) or the folder in which the relevant textures are stored for the 1.12.2 version of the mod, to the best of my knowledge. if/when i have time, ill look into converting some of these. not very good with textures, but a simple color swap cant be that hard. right? * = indicates that the mod is part of Divine Journey 2, which is where i identified most of these. ^ = indicates the the mod is part of Enigmatica 2 Expert Extended (figured it was worth noting). (just edited this in)

These mods don't have support:

These specific GUIs don't have support:

i noticed a few GUIs from mods that already have compatibility that were missing dark mode, mainly caused by forks of the mod.

A Rather Annoying Texture:

ran into this project via E2EE.

roidrole commented 1 month ago

*Modular Machinery non-CE has a number of texture issues which appear to be because of CE support. not sure how viable having compat with both is currently - might want to ask CE to change the name of their texture files? otherwise the only way to have compat is to make a separate texture pack specifically for CE (or for non-CE, just need to be separate).

Are these texture issues default or weirdly? It would help me much if you could provide an example screenshot. In the meantime, I'll fix (in 1.10.0) the guiblueprint as that's a texture not present in CE.

roidrole commented 1 month ago

I'll leave this issue open for a bit because, let's be honest, I probably missed some textures here and there, but they should all be added in version 1.10.0

WaitingIdly commented 1 month ago

heres an example of Modular Machinery textures behaving incorrect in JEI (once again, in DJ2) image the way fluids are represented have changed from a vertical column into a square, and the entire texture atlas is slightly misaligned.

this is the relevant file: Modular Machinery vs Modular Machinery Community Edition. the best way to resolve this might be by asking MMCE to rename the file?

WaitingIdly commented 1 month ago

thanks a lot for taking the time to complete all of these. its really impressive. while checking out the textures in v10.0, i noticed a few things missing or not working properly.

i missed a few textures:

issues with currently existing compat (most are links to png files in this repository):

Bewitchment - [x] Bewitchment [Brew](https://github.com/roidrole/A-Dark-Mode-Addon/blob/main/Dark%20Mode-Addon/assets/bewitchment/textures/gui/jei_brew.png), [Brazier](https://github.com/roidrole/A-Dark-Mode-Addon/blob/main/Dark%20Mode-Addon/assets/bewitchment/textures/gui/jei_brazier.png), [Cauldron](https://github.com/roidrole/A-Dark-Mode-Addon/blob/main/Dark%20Mode-Addon/assets/bewitchment/textures/gui/jei_cauldron.png), and [Frostfire](https://github.com/Um-Mitternacht/Bewitchment/blob/7e3abee418a0a14bf9a40464fcc581996bc97004/src/main/resources/assets/bewitchment/textures/gui/jei_frostfire.png) didnt get converted (the first three are textures in the texture pack, Frostfire isnt).
Extended Crafting Ender Crafting - [x] Extended Crafting Ender Crafting appears oddly in [JEI](https://github.com/roidrole/A-Dark-Mode-Addon/blob/main/Dark%20Mode-Addon/assets/extendedcrafting/textures/jei/ender_crafting.png) with its light arrow texture. the background also appears odd, and may want to be changed so its not such a sharp border? ![image](https://github.com/user-attachments/assets/9bfded4a-5eaa-4d1d-a682-b41d5a088071).
Extended Crafting Quantum Compressor GUI - [x] Extended Crafting [Quantum Compressor GUI](https://github.com/roidrole/A-Dark-Mode-Addon/blob/main/Dark%20Mode-Addon/assets/extendedcrafting/textures/gui/compressor.png) (only the GUI, JEI version doesnt have this issue) is lighter colored than the rest of the Extended Crafting GUIs and is missing the arrow ![image](https://github.com/user-attachments/assets/49eaa16b-a584-4fa1-bc0e-0467a0e7949f) ![image](https://github.com/user-attachments/assets/4dd219c1-0f3e-495f-bd18-20d9ddc5f547)
Roots Loot Category - [x] Roots [Loot Category in JEI](https://github.com/roidrole/A-Dark-Mode-Addon/blob/main/Dark%20Mode-Addon/assets/roots/textures/gui/jei/loot.png) did not get converted

some issues that i do not believe are fixable as a pure texture pack:

Embers Unofficial Extended Life - [x] similar to the MM/MMCE issue, when using the fork of Embers, Embers Unofficial Extended Life, the [Alchemy JEI](https://github.com/Ender-Development/Embers-Extended-Life/blob/rekindled/src/main/resources/assets/embers/textures/gui/jei_alchemy.png) does not appear properly. ![image](https://github.com/user-attachments/assets/e76be15f-5e4e-4648-bc03-6a145dc7d15f)
PackagedAuto JEI - [x] [PackagedAuto JEI](https://github.com/TheLMiffy1111/PackagedAuto/blob/1.12/src/main/java/thelm/packagedauto/integration/jei/category/PackageRecipeCategory.java#L70) has a visual bug which is set directly via Java. ![image](https://github.com/user-attachments/assets/c72c1a63-0f44-4bab-9176-8b5f1fce4d04)
roidrole commented 1 month ago

Extended Crafting Ender Crafting appears oddly in JEI with its light arrow texture. the background also appears odd, and may want to be changed so its not such a sharp border?

The arrow I can fix no problem. However, I struggle to understand what you mean by « not such a sharp border ». I’ll check the textures later, but I believe the gray border is added by JEI itself (maybe extended crafting, but shared across all guis). Are you suggesting I do a grey -> green fade in the background? I guess I could also make the entire background gray, but I want to, where possible, keep the original mod’s feel

roidrole commented 1 month ago

Created an issue on Ember : UEL's github and on MM:CE's github I chose to support Embers:UEL instead of the original embers I'll publish the rest of the missing integrations in the meantime

WaitingIdly commented 1 month ago

when i say "not such a sharp border" i am referring to the sharp line between the green and the gray, yes. checking without this texture pack reveals that this is not a problem on your end, but by Extended Crafting.